[fix][elixir] type casting for dates not working#21216
Draft
efcasado wants to merge 1 commit intoOpenAPITools:masterfrom
Draft
[fix][elixir] type casting for dates not working#21216efcasado wants to merge 1 commit intoOpenAPITools:masterfrom
efcasado wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
efcasado
commented
May 4, 2025
|
|
||
| def decode(value) do | ||
| value | ||
| |> Deserializer.deserialize(:date, :date, nil) |
Contributor
Author
There was a problem hiding this comment.
@wing328, this is what will make the tests pass.
efcasado
commented
May 4, 2025
2fbb9d1 to
55fbeda
Compare
55fbeda to
b076e41
Compare
Merged
Contributor
Author
|
I would suggest parking this change for now and see first what's the appetite for introducing Ecto. #21208 is almost completed and I feel that would give us a more solid implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The refactoring introduced in #21139 around type handling broke the implementation of the hasComplexVars helper function used in the model template. This
PRremovesDate.t,DateTime.t, from the list of primitive types to re-introduce the old behavior.I believe that
Date.tandDateTime.tshould be considered primitive types, but that would require significant changes to the implementation of thehasComplexVarshelper function or themodel.mustachetemplate. I suggest parking this discussion and see how #21208 progresses, since it may introduce a full revamp of how the Elixir generator works with models.This
PRshould unblock the work being done in #21214.@wing328, I decided to strip this out from #21215 because the change affects the Elixir generator and not just the tests. If you think this should be approached differently, the commit can be easily cherry-picked.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)